Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntp: favorites schemas+icons #1191

Merged
merged 3 commits into from
Nov 4, 2024
Merged

ntp: favorites schemas+icons #1191

merged 3 commits into from
Nov 4, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 4, 2024 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/0/0/1208684961069937/f

Description

Just breaking up the schema files + icons to make the implementation easier to review.

Testing Steps

  • No changes here, just merging to reduce PR size

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane mentioned this pull request Nov 4, 2024
Merged
11 tasks
@shakyShane
Copy link
Contributor Author

shakyShane commented Nov 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

This was referenced Nov 4, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

[Beta] Generated file diff

Time updated: Mon, 04 Nov 2024 14:51:41 GMT

New Files 
    - integration/pages/new-tab/icons/ddg-favicon.png
  • integration/pages/new-tab/icons/favicon@2x.png
  • integration/pages/new-tab/letters/a.svg
  • integration/pages/new-tab/letters/b.svg
  • integration/pages/new-tab/letters/c.svg
  • integration/pages/new-tab/letters/d.svg
  • integration/pages/new-tab/letters/e.svg
  • integration/pages/new-tab/letters/f.svg
  • integration/pages/new-tab/letters/g.svg
  • integration/pages/new-tab/letters/h.svg
  • integration/pages/new-tab/letters/i.svg
  • integration/pages/new-tab/letters/j.svg
  • integration/pages/new-tab/letters/k.svg
  • integration/pages/new-tab/letters/l.svg
  • integration/pages/new-tab/letters/m.svg
  • integration/pages/new-tab/letters/n.svg
  • integration/pages/new-tab/letters/o.svg
  • integration/pages/new-tab/letters/p.svg
  • integration/pages/new-tab/letters/q.svg
  • integration/pages/new-tab/letters/r.svg
  • integration/pages/new-tab/letters/s.svg
  • integration/pages/new-tab/letters/t.svg
  • integration/pages/new-tab/letters/u.svg
  • integration/pages/new-tab/letters/v.svg
  • integration/pages/new-tab/letters/w.svg
  • integration/pages/new-tab/letters/x.svg
  • integration/pages/new-tab/letters/y.svg
  • integration/pages/new-tab/letters/z.svg
  • windows/pages/new-tab/icons/ddg-favicon.png
  • windows/pages/new-tab/icons/favicon@2x.png
  • windows/pages/new-tab/letters/a.svg
  • windows/pages/new-tab/letters/b.svg
  • windows/pages/new-tab/letters/c.svg
  • windows/pages/new-tab/letters/d.svg
  • windows/pages/new-tab/letters/e.svg
  • windows/pages/new-tab/letters/f.svg
  • windows/pages/new-tab/letters/g.svg
  • windows/pages/new-tab/letters/h.svg
  • windows/pages/new-tab/letters/i.svg
  • windows/pages/new-tab/letters/j.svg
  • windows/pages/new-tab/letters/k.svg
  • windows/pages/new-tab/letters/l.svg
  • windows/pages/new-tab/letters/m.svg
  • windows/pages/new-tab/letters/n.svg
  • windows/pages/new-tab/letters/o.svg
  • windows/pages/new-tab/letters/p.svg
  • windows/pages/new-tab/letters/q.svg
  • windows/pages/new-tab/letters/r.svg
  • windows/pages/new-tab/letters/s.svg
  • windows/pages/new-tab/letters/t.svg
  • windows/pages/new-tab/letters/u.svg
  • windows/pages/new-tab/letters/v.svg
  • windows/pages/new-tab/letters/w.svg
  • windows/pages/new-tab/letters/x.svg
  • windows/pages/new-tab/letters/y.svg
  • windows/pages/new-tab/letters/z.svg

❌ File only exists in new changeset

@shakyShane shakyShane marked this pull request as ready for review November 4, 2024 09:54
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 4, 2024 09:54
@shakyShane shakyShane force-pushed the extract_entry_points branch from 3f7621e to 627d1c1 Compare November 4, 2024 10:26
@shakyShane shakyShane force-pushed the 11-04-ntp_favorites_schemas_icons branch from 9a24252 to 93f09e0 Compare November 4, 2024 10:26
@shakyShane shakyShane mentioned this pull request Nov 4, 2024
Merged
9 tasks
mgurgel
mgurgel previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m only now noticing the letters O, P, Q have backgrounds while none of the others do. Is that intentional? Looks good otherwise

@shakyShane shakyShane force-pushed the extract_entry_points branch from b4ab524 to e9d7b4a Compare November 4, 2024 14:07
@shakyShane shakyShane force-pushed the 11-04-ntp_favorites_schemas_icons branch 2 times, most recently from 0b8a0da to ceec7c6 Compare November 4, 2024 14:35
Base automatically changed from extract_entry_points to main November 4, 2024 14:43
@shakyShane shakyShane dismissed mgurgel’s stale review November 4, 2024 14:43

The base branch was changed.

@shakyShane shakyShane force-pushed the 11-04-ntp_favorites_schemas_icons branch from ceec7c6 to a592452 Compare November 4, 2024 14:43
@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit e1d0cec
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6728df46af14d700083c5f5e
😎 Deploy Preview https://deploy-preview-1191--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

@mgurgel - fixed the icons! thanks.

@shakyShane shakyShane merged commit 1f8ba4a into main Nov 4, 2024
12 checks passed
@shakyShane shakyShane deleted the 11-04-ntp_favorites_schemas_icons branch November 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgurgel mgurgel mgurgel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakyShane @mgurgel